You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the update and introduction of mapbox/mapbox-java#1500 we're starting to run into mockk/mockk#255 whenever a toBuilder function is called (or even tried to be mocked) on a DirectionsJsonObject. Looks like something in the structure of the class with nested public abstract functions is tripping mockk up.
With the update and introduction of mapbox/mapbox-java#1500 we're starting to run into mockk/mockk#255 whenever a toBuilder function is called (or even tried to be mocked) on a DirectionsJsonObject. Looks like something in the structure of the class with nested public abstract functions is tripping mockk up.
Oooh, can we workaround the issue? Use real objects for instance. For classes like DirectionsJsonObject we usually just need some return values, no verifying or stubbing the answer in a complicated manner.
It may ask for some required properties of course but we can make a utility method for that to avoid copy-paste of unnecessary in this specific test data.
I think so, I pushed a new commit with a workaround that includes real instances and spies. Seems to work fine but definitely a little bit inconvenient.
Merging #6499 (51a2ed8) into main (c4b39fa) will increase coverage by 0.00%.
The diff coverage is n/a.
❗ Current head 51a2ed8 differs from pull request most recent head 67138c7. Consider uploading reports for the commit 67138c7 to get more accurate results
Nice, thank you! I only glanced late Friday and the output was looking intimidatingly long (nearly 50 tests failing). Let me clean up the last pieces and we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip changelogShould not be added into version changelog.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description