Remove redundant MinGW inet_ntop and inet_pton, fix INVALID_SOCKET tautology#122
Merged
gafferongames merged 1 commit intomas-bandwidth:mainfrom Mar 11, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
#ifdef __MINGW32__implementations ofinet_ntopandinet_pton.These are already a part of mingw headers and the conflicting definition of
typedef int socklen_tcauses a conflict with the windows headers (which have the final argument ofinet_ntopbe asize_t) which prevents compilation of the library on mingw.Cast
INVALID_SOCKETto auint32_tto avoid compilers optimizing away the uint32 to uint64 comparison. This will just truncate the bits and give us~(uint32_t)0which is the desired behaviour, and also suppresses the associated compiler warning.