Print warning when disabling SIO_UDP_CONNRESET fails.#124
Print warning when disabling SIO_UDP_CONNRESET fails.#124gafferongames merged 3 commits intomas-bandwidth:mainfrom
Conversation
Signed-off-by: Dan Bechard <dbechrd@gmail.com>
|
Please make this an error and destroy the socket. In fact, without this setting working successfully -- the windows build is quite broken. So it's OK to make it a fatal error. No need for "warning:". ps. if in future you do find actual warning conditions, you can just use NETCODE_LOG_LEVEL_WARN |
Signed-off-by: Dan Bechard <dbechrd@gmail.com>
Signed-off-by: Dan Bechard <dbechrd@gmail.com>
|
Updated level to error and will now the destroy socket on failure. |
|
There's no need to add "error: " to the message -- when you use error log level, it prepends it to your text automatically |
Are you sure? I don't see any logic in |
|
Sorry, I'm getting netcode mixed up with my newer projects (network next etc...) that do the prefixing. Apologies. |
It's tagged as "IMPORTANT" in the comment, so perhaps add a message when it fails? I don't think this particular setting failing to be set warrants destroying the socket, though, so I opted not to do that.