Move /send_leave to GMSL

[S7evinK]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 71.60494% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.24%. Comparing base (2beadf1) to head (185a49a).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
handleleave.go	71.60%	16 Missing and 7 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   58.99%   59.24%   +0.25%     
==========================================
  Files          51       51              
  Lines        7113     7194      +81     
==========================================
+ Hits         4196     4262      +66     
- Misses       2528     2538      +10     
- Partials      389      394       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kegsay]

It would be good to assert the type/state key are correct when queried via CurrentStateEvent.

[kegsay]

Sidenote: this function and others like it will likely need to be modified to support pseudo IDs, as in many cases we pull out the state key and check that it is a user ID, and then check that the domain is correct on it. I would probably structure this as:

• static function HandleSendLeave as it is in this PR
• Pull out the room version immediately.
• Call roomVer.HandleSendLeave(args...) to let room versions decide how to implement this.
• Most room versions will call a private function which does the below code, checking user IDs etc.
• But pseudo IDs will call a custom function which omits these checks.

Whilst the caller could call roomVer.HandleSendLeave this then creates bad symmetry, as there are cases where you don't know the room version at this point (e.g invites).

[kegsay]

This is problematic if v != event.Version().

[kegsay]

The proposal I mentioned in #387 (comment) was to keep this function public, and to serve as the entry point for callers, because:

Whilst the caller could call roomVer.HandleSendLeave this then creates bad symmetry, as there are cases where you don't know the room version at this point (e.g invites).