Skip to content

Adding KVASIR secondary spectrometer mcstas script model#2345

Open
AmalieFalkenberg wants to merge 7 commits intomccode-dev:mainfrom
AmalieFalkenberg:main
Open

Adding KVASIR secondary spectrometer mcstas script model#2345
AmalieFalkenberg wants to merge 7 commits intomccode-dev:mainfrom
AmalieFalkenberg:main

Conversation

@AmalieFalkenberg
Copy link
Copy Markdown

@AmalieFalkenberg AmalieFalkenberg commented Feb 24, 2026

Free-form text area

Please describe what your PR is adding in terms of features or bugfixes:


Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes a new instrument file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)
    • I have ensured that basic use of the instrument is OK (e.g. it compiles?)
    • ... and provided reasonable default parameters in that instrument that produce reasonable output
    • ... and maybe even added a %Example: line to describe expected behaviour
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised
    • My new instrument is added within the examples hierarchy in a folder in the style of examples/ESS/New_stuff/New_stuff.instr
    • My new instrument has a new, unique filename, not clashing with existing example instruments
    • My new instrument requires a data/input file. If the datafile is specific for my instrument I have left it in the same example folder, but if general use I have placed it in the global data folder.

@AmalieFalkenberg
Copy link
Copy Markdown
Author

Adding KVASIR secondary spectrometer mcstas script model

@willend
Copy link
Copy Markdown
Contributor

willend commented Apr 8, 2026

@AmalieFalkenberg it is OK to leave the McStasScript model “in place”, but we prefer having a “good old” .instr file alongside it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants