Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Bugfix: Inverting bool value in rust#447

Merged
mattkjames7 merged 4 commits intomainfrom
bool_inversion_fix
Dec 15, 2025
Merged

Bugfix: Inverting bool value in rust#447
mattkjames7 merged 4 commits intomainfrom
bool_inversion_fix

Conversation

@andrejtonev
Copy link
Copy Markdown
Contributor

@andrejtonev andrejtonev commented Feb 27, 2024

Description

When executing rust procedures, any boolean arguments get negated.

Pull request type

  • Bugfix

Related issues

memgraph/memgraph#3669

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@andrejtonev andrejtonev self-assigned this Feb 27, 2024
@andrejtonev andrejtonev added type: bug Something isn't working and removed type: bug Something isn't working labels Feb 27, 2024
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@andrejtonev andrejtonev added Docs - changelog only Docs - changelog only bug bug labels Feb 29, 2024
@andrejtonev
Copy link
Copy Markdown
Contributor Author

@kgolubic
Changelog: Rust bool value conversion fixed.

@Ignition
Copy link
Copy Markdown

Ignition commented Mar 7, 2024

Maybe add a test to rust/rsmgp-sys/src/value/tests.rs

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kgolubic
Copy link
Copy Markdown

kgolubic commented Apr 3, 2024

@andrejtonev the milestone is missing. Can you please set it?

@andrejtonev
Copy link
Copy Markdown
Contributor Author

@kgolubic mage does not follow the same workflow as memgraph. No milestone is defined.

@sonarqubecloud
Copy link
Copy Markdown

@mattkjames7 mattkjames7 added this pull request to the merge queue Dec 15, 2025
Merged via the queue into main with commit dd455dc Dec 15, 2025
11 checks passed
@mattkjames7 mattkjames7 deleted the bool_inversion_fix branch December 15, 2025 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug bug Docs - changelog only Docs - changelog only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants