Open
Conversation
# Conflicts: # local-server/src/handlers/sessions.rs
The abstraction of BackgroudService don't seem to be as important as before now that there are only two of said services. Also they are quire rigid about how they share data, which is a problem for the new architecture that we are going through where more of the infra creation will be on the local server and then shared. This hopefully simplifies it. The services are simple function calls that we can expand on its params and that their params are not tied into the same constraints. Also as part of this, removed the dynamic loading for booting. this also adds to the simplification of it, but is not a blocker if we want to add the loading again instead of a "progress logging".
…flows # Conflicts: # linkup-cli/src/services/cloudflare_tunnel.rs # linkup-cli/src/services/local_server.rs # linkup-cli/src/services/mod.rs # linkup-cli/src/state.rs
# Conflicts: # linkup-cli/src/commands/local.rs # linkup-cli/src/commands/remote.rs # linkup-cli/src/commands/start.rs # linkup-cli/src/services/local_server.rs # linkup-cli/src/state.rs
augustoccesar
force-pushed
the
ship/rework-sessions-flows
branch
from
2dab76c to
cb98b97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of these changes is to move more of the responsibilities from the CLI to the Local Server and to the Worker.
So instead of doing so many orchestration, it moves the responsibilities closer to the owner of it.
For example, instead of the CLI making a request to both the Worker, then to the Local Server to create the session, and then later to the worker again to create the tunnel, now it makes one request to the Local Server. The Local Server then makes the request to the Worker which internally handles the creation of the tunnel and make sure that everything is in place before sending the information back.
Changes like the above made so that is a chunkier PR since quite a few things had to change for it to be possible.