check that properties is an array before accessing#197
Merged
aaronpk merged 3 commits intomicroformats:masterfrom Aug 23, 2018
aaronpk:issue-196
Merged
check that properties is an array before accessing#197aaronpk merged 3 commits intomicroformats:masterfrom aaronpk:issue-196
aaronpk merged 3 commits intomicroformats:masterfrom
aaronpk:issue-196
Conversation
gRegorLove
reviewed
Aug 23, 2018
tests/Mf2/ParserTest.php
Outdated
|
|
||
| $output = Mf2\parse($input); | ||
| $this->assertEquals([], $output['items'][0]['properties']['comment'][0]['properties']); | ||
| $this->assertEquals([], $output['items'][0]['properties']['comment'][0]['children'][0]['properties']); |
Member
There was a problem hiding this comment.
Minor update: can use assertEmpty() for these.
Member
Author
There was a problem hiding this comment.
what does assertEmpty do if the value is null or not an array? I want to ensure that properties exists and is an array with no items.
Member
There was a problem hiding this comment.
I think null value would pass the assertion; not sure about an empty object. assertInternalType can be used to verify it's an array.
gRegorLove
approved these changes
Aug 23, 2018
Member
gRegorLove
left a comment
gRegorLove
left a comment
There was a problem hiding this comment.
Looks good once the conflict is resolved. Left an inline comment re: assertEmpty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #196