Generate tests in header-parser with Vanilla#1283
Draft
JanKrivanek wants to merge 1 commit intomicrosoft:mainfrom
Draft
Generate tests in header-parser with Vanilla#1283JanKrivanek wants to merge 1 commit intomicrosoft:mainfrom
JanKrivanek wants to merge 1 commit intomicrosoft:mainfrom
Conversation
sandersn
reviewed
Apr 24, 2026
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
From memory, this looks like complete coverage of the properties we neglected to test. Those are low-value but it's nice to have better coverage.
| }); | ||
|
|
||
| it("rejects nonNpm: true with non-string nonNpmDescription", () => { | ||
| const result = validatePackageJson("mylib", makePkg({ nonNpm: true, nonNpmDescription: 123 }), []); |
| }; | ||
| } | ||
|
|
||
| it("rejects missing projects", () => { |
Member
There was a problem hiding this comment.
this is one that's basic enough that I had trouble remembering what it was testing. So it's a good check-your-assumptions case.
| @@ -1,4 +1,15 @@ | |||
| import { validatePackageJson, makeTypesVersionsForPackageJson, License, getLicenseFromPackageJson } from "../src"; | |||
| import { | |||
Member
There was a problem hiding this comment.
don't reformat these; this repo is formatted by prettier (or dprint? can't remember)
Member
There was a problem hiding this comment.
oh that's because there are more things imported now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.