Merged
Conversation
bobstrange
commented
Aug 12, 2020
| nav_search_placeholder: "検索", | ||
| nav_search_aria: "TypeScript サイト内を検索", | ||
| nav_beta: "Search the TypeScript site", | ||
| nav_beta_notification: |
Contributor
Author
There was a problem hiding this comment.
It looks we no longer used both nav_beta and nav_beta_notification on the TopNav.
Can I remove them ?
Contributor
Author
Contributor
|
I'm going to intentionally close and re-open this PR, to see if https://github.com/orta/code-owner-self-merge works |
Contributor
|
Looks like it only affects new PRs 👍🏻 |
Contributor
|
Let's get this in, I'd rather it get merged than stay idle for too long |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #220
Navigation bar translation.
nav