Indentation is busted for extract function

[DanielRosenwasser]

export function interpret(expr: ast.Expression): number {
    switch (expr.kind) {
        case "BinaryExpression":
            const { left, right } = expr;
            return interpret(left) + interpret(right);
    }
}

Extract the entire function body out into its own function.

Expected:

export function interpret(expr): number {
    return newFunction(expr);
}

function newFunction(expr: any) {
    switch (expr.kind) {
        case "BinaryExpression":
            const { left, right } = expr;
            return interpret(left) + interpret(right);
    }
}

Actual:

export function interpret(expr): number {
    return newFunction();

    function newFunction() {
        switch(expr.kind) {
        case "BinaryExpression":
        const { left, right } = expr;
        return interpret(left) + interpret(right);
    }
    }
}

[DanielRosenwasser]

Another broken case:

export function evaluate(node: any): number {
    switch (node.kind) {
        case "Parenthesized":
            while (node.expression.kind === "Parenthesized") {
                node = node.expression;
            }
            return evaluate(node.expression);
    }
}

Gives me:

export function evaluate(node: any): number {
    switch (node.kind) {
        case "Parenthesized":
            var __return: any;
            ({ __return, node } = newFunction(node));
            return __return;
    }
}
function newFunction(node: any) {
while(node.expression.kind === "Parenthesized") {
    node = node.expression;
}
    return { __return: evaluate(node.expression), node };
}

[amcasey]

It's worth mentioning that the repro is from VS Code - it works in VS.

[mhegazy]

does it work in VS because we always call format after applying the change?

[amcasey]

VS does format after applying the change. I don't know whether that's why it works in VS.

[mhegazy]

yeah. that is why. in vs code if you trigger a format later manually it will be fixed. looks like our base indentation gets messed up when we format the new tree.

[drake7707]

I've noticed the same thing happens with the suggested text changes of code fixes, such as implementing the abstract methods from an abstract class