Verbose "extract local constant"

[mjbvz]

From @chrmarti on November 7, 2017 23:40

• VSCode Version: Code - Insiders 1.18.0-insider (098bb77, 2017-11-04T04:35:35.044Z)
• OS Version: Darwin x64 16.7.0
• Extensions: Many

1. In a function, extracting createReporter():

	const subscriptions = context.subscriptions;
	subscriptions.push(createReporter());
	subscriptions.push(createStatusBarItem(azureLogin.api));

2. Results in:

	const subscriptions = context.subscriptions;
	const reporter: { dispose(): any; } = createReporter();

	subscriptions.push(reporter);
	subscriptions.push(createStatusBarItem(azureLogin.api));

3. Unexpected: There is an extra line and a type declaration.

Copied from original issue: microsoft/vscode#37790

[mjbvz]

Two parts to this:

• Don't insert a new line after the extracted constant

• Don't add explicit types if they can be correctly inferred. Addressing this would also fix the errors you can run into where extracting a method can introduce a reference to an type in another file that has not been imported yet