Building composite project with resolveJsonModule fails

[strax]

TypeScript Version: 3.0.0-rc

Search Terms:
resolveJsonModule, composite project, TS6307

Code

Repro at https://github.com/strax/ts-3-json-bug-repro

Expected behavior:

With composite: true and resolveJsonModule: true set in tsconfig.json, JSON modules are resolved in the compilation like they are when the composite compiler option is not set.

Actual behavior:

Running tsc gives the following error:

error TS6307: File '/src/hello.json' is not in project file list. Projects must list all files or use an 'include' pattern.

In addition, trying to include src/hello.json in the files property fails with

error TS6054: File '/src/hello.json' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.

Playground Link:

Related Issues:

[mhegazy]

we should allow .json in files list if --resolveJsonModules is enabled.

[sheetalkamat]

@mhegazy Is assumption that we shouldnt include them through include pattern of config file though?

[mhegazy]

yeah. i think that would be a bigger breaking change.

[cockscomb]

@strax @sheetalkamat @mhegazy Is this problem fixed in TypeScript 3.1.1?

I have tried to use TypeScript 3.1.1 in the repro project, TypeScript gives the following error:

error TS6307: File '/src/hello.json' is not in project file list. Projects must list all files or use an 'include' pattern.

It seems to this problem is still exist.

[sheetalkamat]

@cockscomb you need to have files clause to have the json file("files": ["src/hello.json"] in the tsconfig file). The issue here was it reported unsupported extension (which is not what you are seeing)
In your
cc: @RyanCavanaugh

[raymondfeng]

@sheetalkamat We ran into a similar issue as @cockscomb. tsc complains about json files not in project file list no matter how we tweak tsconfig.json:

{
  "$schema": "http://json.schemastore.org/tsconfig",
  "compilerOptions": {
    "rootDir": "src",
    "composite": true,
    "target": "es2017",
    "outDir": "dist"
  },
  "references": [
    ...
  ],
  "include": [
    "**/*"
  ]
}

None of the following works:

• "include": ["**/*"]
• "include": ["**/*.json", "**/*.ts"]

Do we have to use files to include json files?

[bajtos]

Do we have to use files to include json files?

If I am reading the tests added as part of 49ac60f correctly, then yes, JSON files must be explicitly listed in files section of tsconfig.

@sheetalkamat what is the reasoning behind this requirement/limitation? Would you accept a pull request modifying the behavior of include to cover JSON files too? (I.e. change the test "with resolveJsonModule and include only" to expect a successful compilation.)

https://github.com/Microsoft/TypeScript/blob/49ac60f286972f0349a1f39365bcc6403b3772e5/src/testRunner/unittests/tsbuild.ts#L256-L258