"Move to file" on global code unnecessarily imports/exports, generates invalid code

[DanielRosenwasser]

// main.ts

interface String {
    malkovich(): string;
}

[|String.prototype.malkovich = function (): string {
    return "malkovich";
}|]

1. Select the range.
2. Request "move to a new file"

Current

// newFile.ts
import { String } from "./strs";

String.prototype.malkovich = function (): string {
    return "malkovich";
};

// main.ts
export export export export export export export interface String {
    malkovich(): string;
}

export export export export export export 

Expected

// newFile.ts
String.prototype.malkovich = function (): string {
    return "malkovich";
};

// main.ts
interface String {
    malkovich(): string;
}

[fatcerberus]

Wait, it really produces long strings of export keywords like that? What the heck.

[nick-fallon]

This is very specific to Visual Studio Code dropdown menus. This cannot be reproduced as specified on other IDEs, such as Intellij/JetBrains.

In JetBrains, instead of the dropdown saying "Move to a new file", it says, "Move class '<class-name> to file <class-name>.ts'"

So, it seems to tie in to how the IDE is refactoring things.

[DanielRosenwasser]

The logic is provided from TypeScript's language server. It is possible that this is an issue with VS Code, but I don't see any evidence of that yet. It is more likely that JetBrains is providing its own refactorings that are not powered by our language service.