Revert to inclusion list for JsDoc comment completion#20640
Merged
uniqueiniquity merged 2 commits intomicrosoft:masterfrom Dec 14, 2017
Merged
Revert to inclusion list for JsDoc comment completion#20640uniqueiniquity merged 2 commits intomicrosoft:masterfrom
uniqueiniquity merged 2 commits intomicrosoft:masterfrom
Conversation
ghost
approved these changes
Dec 12, 2017
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
If we merge this, we should add a workaround in visual studio to still produce a comment template if it's explicitly asked for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20089.
We return to explicitly specifying legal code locations for autocompleting JsDoc comment templates, rather than allowing them everywhere besides clearly illegal locations. This change retains the original intended fix of #19544.