Conversation
…it for below ES6 and above ES6
…getter/setter, method, static method,
There was a problem hiding this comment.
not sure you really need that.. it is the else of the if statement with the same condition. just looks like duplication to me,
There was a problem hiding this comment.
I'm not convinced you need to get all the accessors and emit them together. I would just have one emit method, for methods and accessors, and just emit the word "get" or "set" if you need to, the same way you emit "static".
|
I've renamed this PR so that we can find it more easily down the line. |
There was a problem hiding this comment.
This is actually the only place we do a length check before calling emitCommaList. I don't feel that strongly about it, but it's one of those things that's a little odd to see out of place.
Conflicts: src/compiler/checker.ts src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json src/compiler/emitter.ts src/compiler/parser.ts
There was a problem hiding this comment.
you do not need this any more.
There was a problem hiding this comment.
Yep. It will be removed in the upcoming commit
7 participants
Emit classDeclaration natively in ES6. This pull request also set parsing-context for class declaration to be strict mode code if target is es6.
Todo: I will update existed test-cases in ES6 conformance which contains class declaration