Conversation
ghost
reviewed
Oct 22, 2018
Contributor
Author
|
@Andy-MS, @weswigham can you take another look today? I'd like to get this in for this release if possible. |
weswigham
approved these changes
Nov 9, 2018
Member
|
I like the refactors quite a bit - makes the sourcemap parsing/consuming much neater. Still unsure of if the sorted array overlay optimization is strictly required but... eh. |
sheetalkamat
reviewed
Nov 9, 2018
sheetalkamat
reviewed
Nov 9, 2018
sheetalkamat
approved these changes
Nov 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pulls in the changes to the source map emitter from #25492, which cleans up source map generation and parsing throughout the compiler and services.