Report arity errors on call target nodes#54443
Merged
sandersn merged 5 commits intomicrosoft:mainfrom Nov 29, 2023
Merged
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
sandersn
approved these changes
Jun 19, 2023
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
I think this is an improvement, but I'd like to get @DanielRosenwasser 's opinion before merging.
typescript-bot
added
For Backlog Bug
Member
|
I looked at the results again and: my opinion is still that this is an improvement. =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed change is in the same vein as the one that got merged in #52943
I believe that shorter error spans are better. Current arity errors might span a lot of lines, especially in calls that take callback arguments or object/array literals
closes #7734