Always error on overshifts

[weswigham]

To see if making it always an error instead of a suggestion is viable.

[weswigham]

@typescript-bot user test this
@typescript-bot test top600

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
user test this	✅ Started	👀 Results
test top600	✅ Started	✅ Results

[typescript-bot]

@weswigham Here are the results of running the user tests with tsc comparing main and refs/pull/59520/merge:

Something interesting changed - please have a look.

Details

webpack

assembly/tsconfig.json

• [NEW] error TS6807: This operation can be simplified. This shift is identical to result >> 1.
  • assembly/hash/xxhash64.asm.ts#L105
• [NEW] error TS6807: This operation can be simplified. This shift is identical to result >> 0.
  • assembly/hash/xxhash64.asm.ts#L109
  • assembly/hash/xxhash64.asm.ts#L111
• [NEW] error TS6807: This operation can be simplified. This shift is identical to (x & 0xffff) << 0.
  • assembly/hash/xxhash64.asm.ts#L118

[weswigham]

Hm, unsure if those are legitimate errors in webpack or funky AssemblyScript-isms that hint how to handle the numbers to the runtime/compiler.

…

On Fri, Aug 2, 2024, 1:57 PM TypeScript Bot ***@***.***> wrote: @weswigham <https://github.com/weswigham> Here are the results of running the user tests with tsc comparing main and refs/pull/59520/merge: Something interesting changed - please have a look. Details webpack <https://github.com/webpack/webpack.git> assembly/tsconfig.json <https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/tsconfig.json> - [NEW] error TS6807: This operation can be simplified. This shift is identical to result >> 1. - assembly/hash/xxhash64.asm.ts#L105 <https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/hash/xxhash64.asm.ts#L105> - [NEW] error TS6807: This operation can be simplified. This shift is identical to result >> 0. - assembly/hash/xxhash64.asm.ts#L109 <https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/hash/xxhash64.asm.ts#L109> - assembly/hash/xxhash64.asm.ts#L111 <https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/hash/xxhash64.asm.ts#L111> - [NEW] error TS6807: This operation can be simplified. This shift is identical to (x & 0xffff) << 0. - assembly/hash/xxhash64.asm.ts#L118 <https://github.com/webpack/webpack/blob/40479852054817bb7656312177c27739968768a0/assembly/hash/xxhash64.asm.ts#L118> — Reply to this email directly, view it on GitHub <#59520 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWMAMQZ7QREW6DLQZE2RITZPPXERAVCNFSM6AAAAABL5FT6YOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRWGEZTMNJRGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[RyanCavanaugh]

Seems idiomatic in asm? It's declared

let result: u64;

so presumably you can 32-shift it

[typescript-bot]

@weswigham Here are the results of running the top 600 repos with tsc comparing main and refs/pull/59520/merge:

Everything looks good!

[weswigham]

Well, not breaking AssemblyScript u64 idioms is probably as good a reason as any to leave it as a suggestion only outside enums.