.NET: Clarify IResettableExecutor usage comment in workflow sample#4905
Merged
.NET: Clarify IResettableExecutor usage comment in workflow sample#4905
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the .NET workflow sample documentation to better explain when and why IResettableExecutor is needed when reusing workflow instances across multiple runs.
Changes:
- Expanded XML docs in
WorkflowFactory.csto describe shared executor instances andIResettableExecutorexpectations. - Expanded sample-level docs and inline loop comment in
Program.csto explain per-iteration workflow runs and executor reset behavior. - Minor grammar fix in the sample description (“concept of workflows as agents”).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dotnet/samples/03-workflows/Agents/WorkflowAsAnAgent/WorkflowFactory.cs | Adds/clarifies XML documentation around shared executors and resetting state between runs. |
| dotnet/samples/03-workflows/Agents/WorkflowAsAnAgent/Program.cs | Adds sample-level explanation of IResettableExecutor behavior in the interactive loop + minor grammar fix. |
dotnet/samples/03-workflows/Agents/WorkflowAsAnAgent/WorkflowFactory.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/03-workflows/Agents/WorkflowAsAnAgent/WorkflowFactory.cs
Outdated
Show resolved
Hide resolved
…actory.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…actory.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lokitoth
approved these changes
Mar 25, 2026
SergeyMenshykh
approved these changes
Mar 25, 2026
Merged
This was referenced Apr 3, 2026
This was referenced Apr 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify
IResettableExecutorusage comment in workflow sample. There's also a follow-up docs PR to document the interface and recommended usage.Contribution Checklist