Skip to content

.NET: Clarify IResettableExecutor usage comment in workflow sample#4905

Merged
peibekwe merged 3 commits intomainfrom
peibekwe/executors-reset-sample
Mar 25, 2026
Merged

.NET: Clarify IResettableExecutor usage comment in workflow sample#4905
peibekwe merged 3 commits intomainfrom
peibekwe/executors-reset-sample

Conversation

@peibekwe
Copy link
Copy Markdown
Contributor

Description

Clarify IResettableExecutor usage comment in workflow sample. There's also a follow-up docs PR to document the interface and recommended usage.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

@markwallace-microsoft markwallace-microsoft added .NET workflows Related to Workflows in agent-framework labels Mar 25, 2026
@github-actions github-actions bot changed the title Clarify IResettableExecutor usage comment in workflow sample .NET: Clarify IResettableExecutor usage comment in workflow sample Mar 25, 2026
@peibekwe peibekwe marked this pull request as ready for review March 25, 2026 15:36
Copilot AI review requested due to automatic review settings March 25, 2026 15:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the .NET workflow sample documentation to better explain when and why IResettableExecutor is needed when reusing workflow instances across multiple runs.

Changes:

  • Expanded XML docs in WorkflowFactory.cs to describe shared executor instances and IResettableExecutor expectations.
  • Expanded sample-level docs and inline loop comment in Program.cs to explain per-iteration workflow runs and executor reset behavior.
  • Minor grammar fix in the sample description (“concept of workflows as agents”).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dotnet/samples/03-workflows/Agents/WorkflowAsAnAgent/WorkflowFactory.cs Adds/clarifies XML documentation around shared executors and resetting state between runs.
dotnet/samples/03-workflows/Agents/WorkflowAsAnAgent/Program.cs Adds sample-level explanation of IResettableExecutor behavior in the interactive loop + minor grammar fix.

peibekwe and others added 2 commits March 25, 2026 08:43
…actory.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…actory.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@peibekwe peibekwe added this pull request to the merge queue Mar 25, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2026
@peibekwe peibekwe added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit db16a9e Mar 25, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET workflows Related to Workflows in agent-framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants