fix(migrate): add missing jmespath BuildRequires for aws_s3 driver#16614
Merged
christopherco merged 1 commit intotomls/base/mainfrom Apr 12, 2026
Merged
fix(migrate): add missing jmespath BuildRequires for aws_s3 driver#16614christopherco merged 1 commit intotomls/base/mainfrom
christopherco merged 1 commit intotomls/base/mainfrom
Conversation
golang-github-aws-sdk is built in bootstrap mode, which suppresses all golang(...) Requires from its -devel RPM. This means the transitive dependency on github.com/jmespath/go-jmespath is not pulled into the buildroot automatically. Add an explicit BuildRequires to fix the compilation of the aws_s3 source driver. Build verified locally; migrate --version tested in mock.
christopherco
requested review from
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit Go module BuildRequires for migrate to fix buildroot dependency resolution when golang-github-aws-sdk is built in bootstrap mode (which suppresses transitive golang(...) RPM Requires), allowing the aws_s3 source driver to compile.
Changes:
- Introduce a dedicated
migrate.comp.tomlwith an overlay addingBuildRequires: golang(github.com/jmespath/go-jmespath). - Remove the inline
migratecomponent stanza frombase/comps/components.tomlto avoid duplicate component definitions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base/comps/migrate/migrate.comp.toml | Adds an overlay to inject the missing jmespath Go module BuildRequires for migrate. |
| base/comps/components.toml | Removes the inline [components.migrate] entry now that migrate has a dedicated *.comp.toml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anphel31
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golang-github-aws-sdk is built in bootstrap mode, which suppresses all golang(...) Requires from its -devel RPM. This means the transitive dependency on github.com/jmespath/go-jmespath is not pulled into the buildroot automatically. Add an explicit BuildRequires to fix the compilation of the aws_s3 source driver.
Build verified locally; migrate --version tested in mock.