This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Updated serviceBase.js to fix the HTTPS_PROXY#899
Merged
munozemilio merged 6 commits intomicrosoft:masterfrom Aug 3, 2020
Merged
Updated serviceBase.js to fix the HTTPS_PROXY#899munozemilio merged 6 commits intomicrosoft:masterfrom
munozemilio merged 6 commits intomicrosoft:masterfrom
Conversation
Changed the temporary variable name to nodeFetch because the global.fetch wasn't overwriting the variable. This should fix issue 887: microsoft#887
Member
|
@munozemilio Would you please take a look at this PR? |
munozemilio
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the temporary variable name to nodeFetch because the global.fetch wasn't overwriting the variable.
This should fix issue 887:
#887