Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Able to add any extension as a CLI pattern#903

Merged
chrimc62 merged 2 commits intomasterfrom
chrimc/loose
Jul 17, 2020
Merged

Able to add any extension as a CLI pattern#903
chrimc62 merged 2 commits intomasterfrom
chrimc/loose

Conversation

@chrimc62
Copy link
Copy Markdown

This allows adding .uischema files and other extensions to better support testing and ad hoc use.
Checked-in generated C# support files even though projects are just for
testing.

better support testing.
Checked-in generated C# support files even though projects are just for
testing.
@chrimc62 chrimc62 requested a review from munozemilio as a code owner July 16, 2020 17:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #903 into master will increase coverage by 0.48%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
+ Coverage   58.47%   58.95%   +0.48%     
==========================================
  Files         217      218       +1     
  Lines       15313    15846     +533     
  Branches     2102     2148      +46     
==========================================
+ Hits         8954     9342     +388     
- Misses       5812     5921     +109     
- Partials      547      583      +36     
Impacted Files Coverage Δ
packages/dialog/src/library/schemaMerger.ts 79.40% <77.77%> (ø)
...kages/luis/src/commands/luis/application/create.ts 60.00% <0.00%> (-24.22%) ⬇️
...rc/commands/luis/application/assignazureaccount.ts 80.00% <0.00%> (-20.00%) ⬇️
...kages/qnamaker/src/commands/qnamaker/kb/publish.ts 85.71% <0.00%> (-14.29%) ⬇️
...ages/luis/src/commands/luis/application/publish.ts 85.71% <0.00%> (-14.29%) ⬇️
...aker/src/commands/qnamaker/endpointkeys/refresh.ts 85.71% <0.00%> (-14.29%) ⬇️
...ematics/mathematics_helper/AppMathematicsHelper.ts 85.71% <0.00%> (-14.29%) ⬇️
...atics/confusion_matrix/AppBinaryConfusionMatrix.ts 85.71% <0.00%> (-14.29%) ⬇️
packages/luis/src/commands/luis/train/show.ts 89.47% <0.00%> (-10.53%) ⬇️
...ackages/luis/src/commands/luis/application/show.ts 89.47% <0.00%> (-10.53%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe453f...4048be1. Read the comment docs.

@@ -0,0 +1 @@
ef6dea4726012fb20aae4e9fab90c2ca7a8d450b
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

@chrimc62 chrimc62 merged commit 6bd5cf5 into master Jul 17, 2020
@chrimc62 chrimc62 deleted the chrimc/loose branch July 17, 2020 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants