Skip to content

Add missing input validation to SuspendInstanceAsync and ResumeInstan… #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YunchuWang merged 2 commits into from
Feb 27, 2026
Merged

Add missing input validation to SuspendInstanceAsync and ResumeInstan… #652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c3a908
Add missing input validation to SuspendInstanceAsync and ResumeInstan…
YunchuWang Feb 27, 2026
f3ae81d
Merge branch 'main' into wangbill/add-suspend-resume-validation
YunchuWang Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Client/Grpc/GrpcDurableTaskClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ await this.sidecarClient.TerminateInstanceAsync(
public override async Task SuspendInstanceAsync(
string instanceId, string? reason = null, CancellationToken cancellation = default)
{
Check.NotNullOrEmpty(instanceId);
Check.NotEntity(this.options.EnableEntitySupport, instanceId);

P.SuspendRequest request = new()
Expand All @@ -240,6 +241,7 @@ public override async Task SuspendInstanceAsync(
public override async Task ResumeInstanceAsync(
string instanceId, string? reason = null, CancellationToken cancellation = default)
{
Check.NotNullOrEmpty(instanceId);
Comment thread
YunchuWang marked this conversation as resolved.
Check.NotEntity(this.options.EnableEntitySupport, instanceId);

P.ResumeRequest request = new()
Expand Down
Loading