Merged
Conversation
jviau
requested changes
May 31, 2024
nuget.config
Outdated
| <clear/> | ||
| <add key="nuget.org" value="https://www.nuget.org/api/v2/" /> | ||
| <add key="azure-appservice-staging" value="https://www.myget.org/F/azure-appservice-staging/api/v3/index.json" /> | ||
| <add key="azure-appservice" value="https://www.myget.org/F/azure-appservice/api/v3/index.json" /> |
Member
There was a problem hiding this comment.
this will need to be removed or replaced with an ADO feed as well.
Member
Author
There was a problem hiding this comment.
ah, I missed there were two of these. Fixing promptly
Member
Author
There was a problem hiding this comment.
actually, I guess that if we only have nuget.org, we don't really need a nuget.config....but I think we'll eventually want to add the ADO feed so I'll keep it around
Member
There was a problem hiding this comment.
You are expected to always have a nuget.config, because the <clear /> element is important. Otherwise you might pick up a nuget.config in a parent directory, or some other inherited sources. Which leaves this open to a potential supply-chain attack.
jviau
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the DTFx-MSSQL version of this PR: Azure/azure-functions-durable-extension#2842
As part of the 1ES migration, we have new supply chain requirements around our repo's nuget.config files.
In particular, we're getting errors due to use MyGet. This PR removes our MyGet usage. It also addresses warnings regarding missing
<clear/>statements.