Skip to content

Try MSBuild's /Isolate#7619

Closed
Youssef1313 wants to merge 1 commit intomainfrom
dev/ygerges/isolate
Closed

Try MSBuild's /Isolate#7619
Youssef1313 wants to merge 1 commit intomainfrom
dev/ygerges/isolate

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 27, 2026 12:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an MSBuild auto-response file to enable MSBuild’s /Isolate behavior for builds in this repository.

Changes:

  • Introduce Directory.Build.rsp with /Isolate so the flag is applied automatically to MSBuild invocations.

Comment thread Directory.Build.rsp
@@ -0,0 +1 @@
/Isolate
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is still the template/empty, but this change globally alters build behavior for the whole repo. Please update the PR description to include (1) why /Isolate is needed, (2) the expected user-facing impact (CLI build, VS build, CI), and (3) any measured improvement/regression you observed.

Copilot uses AI. Check for mistakes.
Comment thread Directory.Build.rsp
@@ -0,0 +1 @@
/Isolate
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding /Isolate via Directory.Build.rsp applies it to all MSBuild executions (including local dev builds and IDE-driven builds), and may fail on environments where the MSBuild version doesn’t recognize the switch. If the intent is CI-only or limited-scope usage, consider moving this flag into the CI/build scripts instead of Directory.Build.rsp; otherwise, pin/standardize the build toolchain (e.g., via global.json and CI image/tooling updates) so all supported environments use an MSBuild version that supports /Isolate.

Suggested change
/Isolate
# /Isolate flag removed from global response file.
# If isolation is required, pass /Isolate explicitly from CI or build scripts
# instead of applying it to all MSBuild invocations via Directory.Build.rsp.

Copilot uses AI. Check for mistakes.
@Youssef1313
Copy link
Copy Markdown
Member Author

@ViktorHofer We wanted to test if this can give us some perf improvement during build, but looks like we cannot do that today when using Arcade?

.packages/microsoft.dotnet.arcade.sdk/11.0.0-beta.26173.2/tools/Build.proj(176,5): error : MSB4254: The MSBuild task is building project(s) ""/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/11.0.0-beta.26173.2/tools/Tools.proj"" which are not specified in the ProjectReference item. In isolated builds this probably means that the references are not explicitly specified as a ProjectReference item in "/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/11.0.0-beta.26173.2/tools/Build.proj" /mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/11.0.0-beta.26173.2/tools/Build.proj

Any recommendation? Or should we simply abandon this idea?

@ViktorHofer
Copy link
Copy Markdown
Member

ViktorHofer commented Apr 2, 2026

Yeah Arcade seems to be in-compatible with /graph or /isolate. You could try to change that though. Additionally, you could also always experiment with just building the repo with dotnet build directly instead of going through eng/common/build.cmd/sh.

@Youssef1313
Copy link
Copy Markdown
Member Author

Closing for now. Not planned to be investigated soon-ish.

@Youssef1313 Youssef1313 deleted the dev/ygerges/isolate branch April 10, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants