Port getSyntacticNullishnessSemantics changes#1040
Merged
jakebailey merged 1 commit intomicrosoft:mainfrom Jun 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Ports updates from TypeScript PRs to align nullish-coalescing predicate semantics in the Go checker and its test baselines.
- Removes obsolete nullishness errors from the predicateSemantics baselines.
- Adds
TaggedTemplateExpressionandMetaPropertyto always-truthy cases. - Introduces handling for the comma operator by recursing into its right operand.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| testdata/baselines/reference/.../predicateSemantics.errors.txt.diff | Removed extra ?? unreachable-operand error entries. |
| testdata/baselines/reference/.../predicateSemantics.errors.txt | Updated expected error count and pruned removed entries. |
| internal/checker/checker.go | Added TaggedTemplateExpression, MetaProperty, and a comma-operator case. |
Comments suppressed due to low confidence (1)
internal/checker/checker.go:12287
- Matching on
ast.KindCommaTokenwill never occur becausenode.Kindrepresents expression node kinds (e.g.,ast.KindBinaryExpression), not operator tokens. Move comma handling into theast.KindBinaryExpressioncase by checkingnode.AsBinaryExpression().OperatorToken.Kind == ast.KindCommaToken.
case ast.KindCommaToken:
jakebailey
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ports microsoft/TypeScript#60440
ports microsoft/TypeScript#60616
ports microsoft/TypeScript#60402