Port TypeScript PR #58816: Use canHaveFlowNode in checkIfExpressionRefinesParameter#1132
Closed
Port TypeScript PR #58816: Use canHaveFlowNode in checkIfExpressionRefinesParameter#1132
canHaveFlowNode in checkIfExpressionRefinesParameter#1132Conversation
Co-authored-by: andrewbranch <3277153+andrewbranch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Port TypeScript PR #58816: Use
Port TypeScript PR #58816: Use Jun 9, 2025
canHaveFlowNode in checkIfExpressionRefinesParametercanHaveFlowNode in checkIfExpressionRefinesParameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ports TypeScript PR #58816 to the Go codebase, which improves flow node access safety in
checkIfExpressionRefinesParameter.Changes Made
Modified
checkIfExpressionRefinesParameterininternal/checker/checker.goto usecanHaveFlowNodebefore accessing flow nodes:Before:
After:
Rationale
This change mirrors the TypeScript fix that replaced direct flow node access (
expr.flowNode) with a safer pattern that first checks if the expression can have a flow node (canHaveFlowNode(expr) && expr.flowNode).The Go equivalent makes the code more robust by:
Testing
Fixes #1129.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.