Fix debug session not terminating when browser closed from elevated VS#2327
Merged
connor4312 merged 1 commit intomicrosoft:mainfrom Mar 10, 2026
Merged
Conversation
joj
force-pushed
the
fix/unelevated-browser-disconnect
branch
from
e1f85e7 to
e4f0ea3
Compare
When VS runs as Administrator, Chrome/Edge is launched unelevated via the DAP launchUnelevatedRequest. This creates a NonTrackedBrowserProcess with no PID and a never-firing onExit event. When the user closes the browser, the CDP connection is lost, but the reconnection retry loop runs forever because the process exit event never fires to cancel it. Fix: if launching unelevated, canReconnect is always false Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joj
force-pushed
the
fix/unelevated-browser-disconnect
branch
from
e4f0ea3 to
8f50ca7
Compare
connor4312
approved these changes
Mar 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When VS runs as Administrator, Chrome/Edge is launched unelevated via the DAP launchUnelevatedRequest. This creates a NonTrackedBrowserProcess with no PID and a never-firing onExit event. When the user closes the browser, the CDP connection is lost, but the reconnection retry loop runs forever because the process exit event never fires to cancel it.
Fix: limit CDP reconnection retries to 3 attempts for non-tracked processes (identified by pid === undefined). Tracked processes continue to retry indefinitely as before, since their exit event reliably stops the loop.