Fix os.tmpDir() deprecation warning in WebKit Developer Tools Console#896
Conversation
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 64.07% 64.06% -0.01%
==========================================
Files 260 260
Lines 12013 12032 +19
Branches 2134 2142 +8
==========================================
+ Hits 7697 7708 +11
- Misses 4307 4315 +8
Partials 9 9
Continue to review full report at Codecov.
|
|
Unfortunately we are close to the release of a new version sand are at code freeze. Will merge this for the next release. Thanks |
|
One thing I'd check if said extension version matches vscode 1.18 listed in dependencies (rather than the latest). We don't normally require latest vscode since users don't always upgrade VSC immediately. |
DonJayamanne
left a comment
There was a problem hiding this comment.
@osya
Please could you resolve the merge conflict with the yarn.lock file, I'd like to approve this an get this merged asap.
Add a news entry file.
In the WebKit Developer Tools Console there is a
DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead. There are some corresponding issues:All these issues are closed and recommended to search the root cause in VS Code extensions. I searched through source code of my installed extensions but can't find
tmpDirthere. Then I found thatvscode-python(and probably some other VS Code extensions) uses oldvscode-extension-telemetry(v. 0.0.5) which uses old version ofapplocationinsights(v. 0.15.6), which usesos.tmpDir()inSender.js. I changed version of vscode-extension-telemetryto 0.0.14, which usesapplocationinsights1.0.1, which usesos.tmpdir()inSender.js`.I launched it and it seems worked. It is not tested because there are many issues with tests in this repository