Skip to content

Fix os.tmpDir() deprecation warning in WebKit Developer Tools Console#896

Merged
DonJayamanne merged 3 commits intomicrosoft:masterfrom
osya:bug/os_tmpDir_deprecation_warning
Mar 13, 2018
Merged

Fix os.tmpDir() deprecation warning in WebKit Developer Tools Console#896
DonJayamanne merged 3 commits intomicrosoft:masterfrom
osya:bug/os_tmpDir_deprecation_warning

Conversation

@osya
Copy link
Copy Markdown

@osya osya commented Feb 25, 2018

In the WebKit Developer Tools Console there is a DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead. There are some corresponding issues:

All these issues are closed and recommended to search the root cause in VS Code extensions. I searched through source code of my installed extensions but can't find tmpDir there. Then I found that vscode-python (and probably some other VS Code extensions) uses old vscode-extension-telemetry (v. 0.0.5) which uses old version of applocationinsights (v. 0.15.6), which uses os.tmpDir() in Sender.js. I changed version of vscode-extension-telemetryto 0.0.14, which usesapplocationinsights1.0.1, which usesos.tmpdir()inSender.js`.

I launched it and it seems worked. It is not tested because there are many issues with tests in this repository

@msftclas
Copy link
Copy Markdown

msftclas commented Feb 25, 2018

CLA assistant check
All CLA requirements met.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2018

Codecov Report

Merging #896 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
- Coverage   64.07%   64.06%   -0.01%     
==========================================
  Files         260      260              
  Lines       12013    12032      +19     
  Branches     2134     2142       +8     
==========================================
+ Hits         7697     7708      +11     
- Misses       4307     4315       +8     
  Partials        9        9
Impacted Files Coverage Δ
src/client/common/featureDeprecationManager.ts 53.42% <0%> (-0.28%) ⬇️
src/client/linters/lintingEngine.ts 91.22% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74fb50...e757afe. Read the comment docs.

@DonJayamanne
Copy link
Copy Markdown

Unfortunately we are close to the release of a new version sand are at code freeze. Will merge this for the next release. Thanks

@MikhailArkhipov
Copy link
Copy Markdown

One thing I'd check if said extension version matches vscode 1.18 listed in dependencies (rather than the latest). We don't normally require latest vscode since users don't always upgrade VSC immediately.

@brettcannon brettcannon added this to the March 2018 milestone Mar 6, 2018
Copy link
Copy Markdown

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osya
Please could you resolve the merge conflict with the yarn.lock file, I'd like to approve this an get this merged asap.

@DonJayamanne DonJayamanne merged commit c140847 into microsoft:master Mar 13, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants