Skip to content

Simplify debug configuration entries#958

Merged
DonJayamanne merged 12 commits intomicrosoft:masterfrom
DonJayamanne:simplifyDebugConfig
Mar 9, 2018
Merged

Simplify debug configuration entries#958
DonJayamanne merged 12 commits intomicrosoft:masterfrom
DonJayamanne:simplifyDebugConfig

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #881

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2018

Codecov Report

Merging #958 into master will decrease coverage by 0.28%.
The diff coverage is 95.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   64.24%   63.96%   -0.29%     
==========================================
  Files         260      260              
  Lines       12031    12048      +17     
  Branches     2130     2139       +9     
==========================================
- Hits         7729     7706      -23     
- Misses       4293     4333      +40     
  Partials        9        9
Impacted Files Coverage Δ
src/client/debugger/mainV2.ts 0% <0%> (ø) ⬆️
...lient/debugger/configProviders/pythonV2Provider.ts 100% <100%> (ø)
.../client/debugger/configProviders/pythonProvider.ts 100% <100%> (ø) ⬆️
src/client/debugger/index.ts 100% <100%> (ø) ⬆️
...rc/client/debugger/configProviders/baseProvider.ts 90.47% <96.77%> (-2.26%) ⬇️
src/client/linters/errorHandlers/notInstalled.ts 33.33% <0%> (-61.12%) ⬇️
src/client/linters/errorHandlers/errorHandler.ts 77.77% <0%> (-22.23%) ⬇️
src/client/common/logger.ts 33.33% <0%> (-20%) ⬇️
src/client/common/application/applicationShell.ts 23.07% <0%> (-7.7%) ⬇️
src/client/linters/baseLinter.ts 85.41% <0%> (-6.25%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318aa39...4d1c2e3. Read the comment docs.

@DonJayamanne DonJayamanne force-pushed the simplifyDebugConfig branch from a80d4d7 to ee99e57 Compare March 8, 2018 23:17
@brettcannon brettcannon added this to the March 2018 milestone Mar 9, 2018
@DonJayamanne DonJayamanne merged commit ae7a342 into microsoft:master Mar 9, 2018
@DonJayamanne DonJayamanne deleted the simplifyDebugConfig branch March 15, 2018 16:58
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify debug configuration

2 participants