Read-only --extensions-dir break remote extension installation

[bjornfor]

Does this issue occur when all extensions are disabled?: No. (The issue is about installing extensions on a remote system.)

• VS Code Version: 1.67.2
• OS Version: Ubuntu 18.04

Steps to Reproduce:

1. Start VSCode with code --extensions-dir /path/to/read-only-tree-of-extensions. (Why read-only? Because that's how Nix does software deployment. This command just reproduces how vscode-with-extensions from Nixpkgs works.)
2. Check that the extensions from the local tree is available.
3. Open a remote ssh connection and try to install one of the local extensions to the remote system.
4. VSCode errors out with Unable to write file '/home/$USER/.vscode-server/extensions/.6661fce6-c826-4679-8f01-8421850781b5/package.json' (EntryWriteLocked (FileSystemError): Error: EACCES: permission denied, open '/home/$USER/.vscode-server/extensions/.6661fce6-c826-4679-8f01-8421850781b5/package.json')

It seems VSCode first copies files from the local system /path/to/read-only-tree-of-extensions to ~/.vscode-server/ on the remote host and then tries to update ~/.vscode-server/extensions/.UUID/package.json (still on the remote), which fails because the file still has read-only permissions.

I tried to chmod the files myself, but it seems VSCode creates a new UUID every time, so it doesn't work.

When copying extensions/files from somewhere to $HOME on a remote machine, with the intention to update some of the files, I think it's reasonable to explicitly set the writeable bit on said files, after the copy operation completes.

[sandy081]

This is probably because when we install a local extension into remote, we zip the local extension and unzip it on remote. I suspect that while zipping we are also including file modes.

[bjornfor]

This seems like something a developer who is familiar with the code can fix quickly, right? Or alternatively, any hints as to where that code exists and I can try to fix it myself?

[sandy081]

I own this code and if you are interested to contribute the fix, you are welcome and appreciated. Here is the code pointer

vscode/src/vs/platform/extensionManagement/node/extensionManagementService.ts

Lines 107 to 112 in 1a7d1b4

	async zip(extension: ILocalExtension): Promise<URI> {
	this.logService.trace('ExtensionManagementService#zip', extension.identifier.id);
	const files = await this.collectFiles(extension);
	const location = await zip(joinPath(this.environmentService.tmpDir, generateUuid()).fsPath, files);
	return URI.file(location);
	}

[pwaller]

Any luck so far? Also hitting this and interested in a fix.

[vscodenpa]

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

[bjornfor]

This is still important to me, please re-open. Without this there is no reproducible and/or offline installation option (AFAIK).

[bjornfor]

@isidorn: How can a (presumably) trivial fix to chmod +w some files before changing them be out of scope? I understand it doesn't have high priority for you, but please re-open.

[pwaller]

@isidorn Sorry for the noise, but seconding this for visibility. Please reopen. It means that when I use vscode on nixos to access a remote, things are broken when they shouldn't be, and it's not straightforward to fix as a user.

[isidorn]

Let's reopen and for now leave on the backlog.