Skip to content

Add strongForeground color for enhanced text legibility#312993

Merged
mrleemurray merged 2 commits intomainfrom
mrleemurray/strange-silver-bonobo
Apr 28, 2026
Merged

Add strongForeground color for enhanced text legibility#312993
mrleemurray merged 2 commits intomainfrom
mrleemurray/strange-silver-bonobo

Conversation

@mrleemurray
Copy link
Copy Markdown
Contributor

Introduce a new strongForeground color to improve text legibility against various backgrounds. This color provides maximum contrast for text or icons that require high visibility.

Copilot AI review requested due to automatic review settings April 28, 2026 09:38
@mrleemurray mrleemurray enabled auto-merge (squash) April 28, 2026 09:38
@mrleemurray mrleemurray self-assigned this Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

blocks-ci screenshots changed

Replace the contents of test/componentFixtures/blocks-ci-screenshots.md with:

Updated blocks-ci-screenshots.md
<!-- auto-generated by CI — do not edit manually -->

#### editor/codeEditor/CodeEditor/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/cb32a3e854b5734fe5aaca2318f2e0a42ee821b05ea97883ea42c5ba95edb3c3)

#### editor/codeEditor/CodeEditor/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/42624fbba5e0db7f32c224b5eb9c5dd3b08245697ae2e7d2a88be0d7c287129b)

#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/4baed4b05eeb8aadc8bc2dc633abfc87054cdeea4c35b7a655766063bcfedfed)

#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/b9d098d8ccc2bdb6b816537f14b1f1f3c10dadf294fc0b28d03d6e5a34eaf4c8)

#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/4baed4b05eeb8aadc8bc2dc633abfc87054cdeea4c35b7a655766063bcfedfed)

#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/b9d098d8ccc2bdb6b816537f14b1f1f3c10dadf294fc0b28d03d6e5a34eaf4c8)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new global theme color token, strongForeground, intended to provide a highest-contrast foreground option for text/icons where maximum legibility is required.

Changes:

  • Register new theme color strongForeground with light/dark and HC defaults.
  • Add --vscode-strongForeground to the Stylelint known CSS variables list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/platform/theme/common/colors/baseColors.ts Adds strongForeground to the base color registry with localized description and defaults.
build/lib/stylelint/vscode-known-variables.json Whitelists the generated CSS variable --vscode-strongForeground for Stylelint validation.

Comment thread src/vs/platform/theme/common/colors/baseColors.ts Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mrleemurray mrleemurray merged commit 8d97209 into main Apr 28, 2026
39 of 41 checks passed
@mrleemurray mrleemurray deleted the mrleemurray/strange-silver-bonobo branch April 28, 2026 10:46
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants