Skip to content

feat: implement arch-specific types support (issue #4299)#4311

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/explore-solutions-to-issue-4299
Draft

feat: implement arch-specific types support (issue #4299)#4311
Copilot wants to merge 3 commits intomasterfrom
copilot/explore-solutions-to-issue-4299

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

  • Part 1: Add target() method to Clang builder
  • Part 2: Add #[arch(...)] shorthand in writer/reader
    • write_arch_attr() moved to writer/mod.rs, emits #[arch(...)]
    • Arch attribute for struct/union/fn writers
    • read_arch(), parse_arch_bitmask(), arch_name_to_bits() in reader
    • emit_arch_attribute() in attribute_ref.rs
    • encode_attrs skips arch globally
    • encode_struct, encode_union, encode_fn handle #[arch(...)]
    • Updated golden files (roundtrip/arches.rdl, nested-arches.rdl)
    • Negative tests for invalid arch names
  • Part 3: Multi-arch merge in windows-metadata Merger
    • arch_input(path, arch_bits) method
    • Arch-aware merge() logic
    • write_type with arch_override
    • write_attributes_with_arch() helper
    • test_arch test + golden files
  • cargo fmt

Copilot AI and others added 2 commits April 27, 2026 00:18
@kennykerr
Copy link
Copy Markdown
Collaborator

@copilot fmt

Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/fc6fe9bc-1c8b-4b7e-82c6-fef7cfb4f5fa

Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 27, 2026

@copilot fmt

Done — formatted in d72d4e3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants