feat: implement arch-specific types support (issue #4299)#4311
Draft
feat: implement arch-specific types support (issue #4299)#4311
Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/2109417e-09ef-4ea0-85cb-b7cd994610ad Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/2109417e-09ef-4ea0-85cb-b7cd994610ad Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
kennykerr
April 27, 2026 00:20
View session
Collaborator
|
@copilot fmt |
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/fc6fe9bc-1c8b-4b7e-82c6-fef7cfb4f5fa Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
target()method toClangbuilder#[arch(...)]shorthand in writer/readerwrite_arch_attr()moved towriter/mod.rs, emits#[arch(...)]read_arch(),parse_arch_bitmask(),arch_name_to_bits()in readeremit_arch_attribute()inattribute_ref.rsencode_attrsskipsarchgloballyencode_struct,encode_union,encode_fnhandle#[arch(...)]roundtrip/arches.rdl,nested-arches.rdl)windows-metadataMergerarch_input(path, arch_bits)methodmerge()logicwrite_typewitharch_overridewrite_attributes_with_arch()helpertest_archtest + golden filescargo fmt