Skip to content

Require AuthProvider param for all BaseClient constructor and LargeFileUpload spec alignment#457

Merged
andrueastman merged 1 commit intofeature/3.0from
andrueastman/fixLargeFileUpload
Jul 12, 2022
Merged

Require AuthProvider param for all BaseClient constructor and LargeFileUpload spec alignment#457
andrueastman merged 1 commit intofeature/3.0from
andrueastman/fixLargeFileUpload

Conversation

@andrueastman
Copy link
Copy Markdown
Contributor

@andrueastman andrueastman commented Jul 12, 2022 •
edited by ghost
Loading

This PR closes #450, closes #215 and closes #132

Changes include:

  • Ensure all BaseClient constructors take an AuthProvider
  • Add support for passing a cancellationToken to the LargeFileUploadTask to fully align with the spec.
  • Adds tests to capture cancelled cancellationTokens
Microsoft Reviewers: Open in CodeFlow

@andrueastman andrueastman added the Kiota Is solved by Kiota or will be addressed in Kiota label Jul 12, 2022
@andrueastman andrueastman added this to the Kiota milestone Jul 12, 2022
@andrueastman andrueastman self-assigned this Jul 12, 2022
This was linked to issues Jul 12, 2022
Require AuthProvider param for all BaseClient constructors #450
Closed
Align large file upload on new spec #215
Closed
Add support for CancellationToken in LargeFIleUploadTask #132
Closed
@andrueastman andrueastman marked this pull request as ready for review July 12, 2022 08:18
@andrueastman andrueastman enabled auto-merge July 12, 2022 08:18
@andrueastman andrueastman requested a review from baywet July 12, 2022 08:18
baywet
baywet approved these changes Jul 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrueastman is on fire! 🔥🔥🔥

@andrueastman andrueastman merged commit 34185e8 into feature/3.0 Jul 12, 2022
@andrueastman andrueastman deleted the andrueastman/fixLargeFileUpload branch July 12, 2022 13:02
@baywet
Copy link
Copy Markdown
Member

baywet commented Jul 12, 2022

PS: the issue were not automatically closed since this is not targeting the main branch.

This was referenced Jul 13, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

1 more reviewer

@baywet baywet baywet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andrueastman andrueastman

Labels

Kiota Is solved by Kiota or will be addressed in Kiota

Projects

None yet

Milestone

V3

2 participants

@andrueastman @baywet