Conversation
Contributor
Author
|
This PR depends on #370 |
baywet
suggested changes
Jan 4, 2021
baywet
reviewed
Jan 5, 2021
baywet
suggested changes
Jan 12, 2021
ddyett
reviewed
Jan 12, 2021
ddyett
reviewed
Jan 12, 2021
ddyett
reviewed
Jan 12, 2021
ddyett
reviewed
Jan 12, 2021
ddyett
reviewed
Jan 12, 2021
Contributor
|
may also be good to have a pure javascript sample at some point |
zengin
suggested changes
Jan 13, 2021
Contributor
zengin
left a comment
There was a problem hiding this comment.
Sorry for nitpicking on the typos. I added those comments as most of them appear in public documentation (MD files).
Contributor
Author
Thanks for point those out. I should be careful about that. |
Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
Contributor
Author
Added. |
ddyett
approved these changes
Jan 20, 2021
zengin
approved these changes
Jan 20, 2021
Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
baywet
approved these changes
Jan 27, 2021
|
Hey folks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TokenCredentialAuthenticationProvideroption so that authentication can be done using the@azure/identity- tokenCredentialclasses.TokenCredentialAuthenticationProviderusingAuthenticationCodeFlow and ClientCredentialFlow@microsoft/microsoft-graph-client/authProviders/azureTokenCredentials. This is a workaround for the limitations Recommendation for exposing multiple TypeScript modules from single NPM package microsoft/TypeScript#8305 ,Support for NodeJS 12.7+ package exports microsoft/TypeScript#33079.
The idea for using a submodule structure to export the authProviderOptions is because -
We are not exporting
TokenCredentialAuthenticationProviderandImplicitMsalAuthenticationProviderin thesrc/index.ts. This makesmsaland@azure/identityan optional dependency for the user of the sdk. Marking them as option using peerDependenciesMeta.ImplicitMSALAuthenticationProvider is not exported in index.js #230 -
ImplicitMsalAuthenticationProviderwas not exported in JS SDK version < 2.1 as usingmsalwas optional but exporting in the index file would makemsala runtime dependency.To import
TokenCredentialAuthenticationProviderandImplicitMsalAuthenticationProvider, the paths would beAdded
tsconfig-sub-x.jsonto build the project using TypeScript Project References