Skip to content

Sebastienlevert/fix chaos handler random#429

Merged
nikithauc merged 4 commits intomicrosoftgraph:3.0.0from
sebastienlevert:sebastienlevert/fix-chaos-handler-random
Apr 20, 2021
Merged

Sebastienlevert/fix chaos handler random#429
nikithauc merged 4 commits intomicrosoftgraph:3.0.0from
sebastienlevert:sebastienlevert/fix-chaos-handler-random

Conversation

@sebastienlevert
Copy link
Copy Markdown
Contributor

Motivation

Brings the ChaosHandler to support interactive scenarios. Will allow for randomized requests to fail but also retries attemps to both fail and succeed based on the percentage provided.

Closing issues

Fixes #427

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sebastienlevert sebastienlevert changed the base branch from dev to 3.0.0 April 19, 2021 20:34
Comment thread src/middleware/ChaosHandler.ts Outdated
@nikithauc
Copy link
Copy Markdown
Contributor

@sebastienlevert Thank you for your contribution!

Copy link
Copy Markdown
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @sebastienlevert ! a few minor suggestions

Comment thread src/middleware/ChaosHandler.ts Outdated
Comment thread test/common/middleware/ChaosHandler.ts Outdated
Comment thread src/middleware/ChaosHandler.ts Outdated
Co-authored-by: Nikitha Chettiar <nikithauc@gmail.com>
@nikithauc nikithauc merged commit e238b45 into microsoftgraph:3.0.0 Apr 20, 2021
@sebastienlevert sebastienlevert deleted the sebastienlevert/fix-chaos-handler-random branch February 14, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChaosHandler cannot be used in interactive scenarios

3 participants