Adds Error Content Support

[Ndiritu]

Throws a GraphServiceException containing an error object for 4xx and 5xx responses

Closes #19

[ddyett]

please open issues to link these PRs to, so that work can be tracked.

[Ndiritu]

please open issues to link these PRs to, so that work can be tracked.

The issues are currently on the v1 repo. Working with the team to transfer all Core issues to this repo & switch to tracking high level goals using ZenHub

[Ndiritu]

@MIchaelMainer updated this PR to throw native InvalidArgumentException for validation errors, GraphClientException for 4xx and GraphServiceException for 5xx

[Ndiritu]

please open issues to link these PRs to, so that work can be tracked.

The issues are currently on the v1 repo. Working with the team to transfer all Core issues to this repo & switch to tracking high level goals using ZenHub

@ddyett @shemogumbe @roinochieng Core issues have been transferred to this repo and linked to epics to the best of my knowledge (subject to review & change with the rest of the team)

[MIchaelMainer]

Conditionally approved per the answer to my question: This change brings up another consideration. GraphClientException::GraphResponseException is very appropriate for 4xx errors, how do we specify a client exception that does not represent a 4xx error response?

We may want something like:
GraphClientException::Exception -- exceptions that occur before an HTTP request is made, or more generally, applicable to how the client throws an exception independent of request/response.
GraphClientResponseException::GraphResponseException -- 4xx exception.

I'd like to get your thoughts.

[Ndiritu]

Conditionally approved per the answer to my question: This change brings up another consideration. GraphClientException::GraphResponseException is very appropriate for 4xx errors, how do we specify a client exception that does not represent a 4xx error response?

We may want something like:
GraphClientException::Exception -- exceptions that occur before an HTTP request is made, or more generally, applicable to how the client throws an exception independent of request/response.
GraphClientResponseException::GraphResponseException -- 4xx exception.

I'd like to get your thoughts.

Unable to figure out a use-case for a non-4xx client exception that wouldn't be covered by a native exception type e.g. InvalidArgumentException for validation errors etc.

My understanding from the Teams thread was that all other exceptions would be native?

[MIchaelMainer]

That's fair.