patch for multiple addresses with unquoted display parts#9
Open
crowbot wants to merge 1 commit intomikel:masterfrom
Open
patch for multiple addresses with unquoted display parts#9crowbot wants to merge 1 commit intomikel:masterfrom
crowbot wants to merge 1 commit intomikel:masterfrom
Conversation
…atching in case of multiple addresses with unquoted display names.
|
+1 I'm seeing this as manifested as an email with 2+ CCs parses as a TMail::Mail object with only 1 CC; the last CC. Even though TMail isn't official supported, it seems that this bug should probably be fixed for all the existing Rails 2 codebases out there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce scope of special case for matching '@' in display name - was matching in case of multiple addresses with unquoted display names. Not a great way to patch but have added test case in case anyone can do a better job.