Conversation
|
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansmultiformats |
|
@BigLep action items from yesterday:
|
Using the same names and individuals of https://github.com/orgs/libp2p/teams/js-libp2p-dev and https://github.com/orgs/ipfs/teams/helia-dev
|
Related ownership issue: multiformats/js-multiformats#273 @achingbrain : please take a look to see if this looks good to you |
| - lukehoersten | ||
| privacy: closed | ||
| Helia Dev: | ||
| # This should match https://github.com/orgs/ipfs/teams/helia-dev |
There was a problem hiding this comment.
We can codify this! We can add a rule to https://github.com/multiformats/github-mgmt/blob/master/scripts/src/actions/fix-yaml-config.ts that would look up the team members at https://github.com/orgs/ipfs/teams/helia-dev and set them here too.
There was a problem hiding this comment.
Do we still want to do this?
Co-authored-by: Alex Potsides <alex@achingbrain.net>
Co-authored-by: Alex Potsides <alex@achingbrain.net>
|
@achingbrain : feedback incorporated. Are you ok to approve/merge? |
achingbrain
left a comment
There was a problem hiding this comment.
LGTM, pending resolving the comment about automating the synching of team members from @galargh.
|
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansTerraform plans are too long to post as a comment. Please inspect Plan > Comment > Show terraform plans instead. |
|
I'm going to close this PR because it got accidentally pulled into testing of other features. I'm going to recreate and merge it after the testing's complete and then I'll report back here that the PR was merged. |
FYI, @BigLep, you can create teams and CODEOWNERS file both from GitHub Management (if we want to contain the discussion about both to a single place).