es circuit breaker#1484
Merged
dragos-rebegea merged 7 commits intodevelopmentfrom Apr 23, 2025
Merged
Conversation
|
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
gabrielmatei
approved these changes
Apr 16, 2025
stefangutica
approved these changes
Apr 16, 2025
cfaur09
reviewed
Apr 22, 2025
| this.enabled = apiConfigService.isElasticCircuitBreakerEnabled(); | ||
| this.config = apiConfigService.getElasticCircuitBreakerConfig(); | ||
| this.logger.log(`ES Circuit Breaker. Enabled: ${this.enabled}. Duration threshold: ${this.config.durationThresholdMs}ms. | ||
| FailureCountThreshold: ${this.config.failureCountThreshold}ms. FailureCountThreshold: ${this.config.failureCountThreshold}`); |
Contributor
There was a problem hiding this comment.
failureCountThreshold value is applied multiple times
dragos-rebegea
added a commit
that referenced
this pull request
Apr 23, 2025
This reverts commit eb0234a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
elasticsearchservice is under high load, we should limit the number of requests we sendProposed Changes
How to test