Added option to filter out a snippet of the replacement payload using the same regex.#21
Merged
nefrob merged 8 commits intonefrob:masterfrom Oct 20, 2024
Merged
Conversation
Aukevanoost
changed the title
nefrob
reviewed
Oct 14, 2024
Owner
There was a problem hiding this comment.
Thanks for the PR!
I'm wary of adding support for transformations of the input when the main goal of this action is to provide simple transformation of a PR body.
That being said, this is fairly simple like the rest of this action and could provide value for basic use cases.
Aukevanoost
commented
Oct 15, 2024
nefrob
approved these changes
Oct 20, 2024
Owner
nefrob
left a comment
nefrob
left a comment
There was a problem hiding this comment.
LGTM. I'll flup with some general cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows for Regex in the payload as well, for example if you only need a part of the input file you're reading.
No breaking changes, only an optional flag that will filter out the regex from the replacement payload and only update the description with the (first) match of the regex.