Call to a member function getUsersFavoritingObject() on null

[kesselb]

Steps to reproduce

1. Create a public share link for a folder
2. Select "Allow upload and editing"
3. Open share in private windows
4. Delete a file

Expected behaviour

Delete the file

Actual behaviour

Error deleting file "xzy".

{"reqId":"X7IEDmn0VvhEEs5hBSOq","level":1,"time":"2020-09-21T18:33:31+00:00","remoteAddr":"192.168.10.1","user":"--","app":"no app in context","method":"DELETE","url":"/public.php/webdav/Test.md","message":"Deprecated event type for {\"[object] (OCP\\SabrePluginEvent)\":{\"*statusCode\":200,\"*message\":\"\",\"*server\":{\"[object] (OCA\\DAV\\Connector\\Sabre\\Server)\":{\"tree\":\"[object] (OCA\\DAV\\Connector\\Sabre\\ObjectTree)\",\"*baseUri\":\"/public.php/webdav/\",\"httpResponse\":\"[object] (Sabre\\HTTP\\Response)\",\"httpRequest\":\"[object] (Sabre\\HTTP\\Request)\",\"sapi\":\"[object] (Sabre\\HTTP\\Sapi)\",\"*plugins\":[],\"transactionType\":null,\"protectedProperties\":{\"...\":\"Over 20 items, aborting normalization\"},\"debugExceptions\":false,\"resourceTypeMapping\":[],\"enablePropfindDepthInfinity\":true,\"xml\":\"[object] (Sabre\\DAV\\Xml\\Service)\",\"*listeners\":{\"...\":\"Over 20 items, aborting normalization\"},\"*wildcardListeners\":[],\"*listenerIndex\":[],\"*logger\":null}},\"Symfony\\Contracts\\EventDispatcher\\EventpropagationStopped\":false}}: null","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36","version":"21.0.0.0"}
{"reqId":"X7IEDmn0VvhEEs5hBSOq","level":4,"time":"2020-09-21T18:33:31+00:00","remoteAddr":"192.168.10.1","user":"--","app":"webdav","method":"DELETE","url":"/public.php/webdav/Test.md","message":{"Exception":"Error","Message":"Call to a member function getUsersFavoritingObject() on null","Code":0,"Trace":[{"file":"/home/vagrant/code/nextcloud/apps/activity/lib/FilesHooks.php","line":242,"function":"getFileChangeActivitySettings","class":"OCA\\Activity\\FilesHooks","type":"->","args":[1793,["admin"]]},{"file":"/home/vagrant/code/nextcloud/apps/activity/lib/FilesHooks.php","line":177,"function":"addNotificationsForFileAction","class":"OCA\\Activity\\FilesHooks","type":"->","args":["/AAAAAAA/Test.md","file_deleted","deleted_self","deleted_by"]},{"file":"/home/vagrant/code/nextcloud/apps/activity/lib/FilesHooksStatic.php","line":63,"function":"fileDelete","class":"OCA\\Activity\\FilesHooks","type":"->","args":["/AAAAAAA/Test.md"]},{"file":"/home/vagrant/code/nextcloud/lib/private/legacy/OC_Hook.php","line":110,"function":"fileDelete","class":"OCA\\Activity\\FilesHooksStatic","type":"::","args":[{"run":true,"path":"/AAAAAAA/Test.md"}]},{"file":"/home/vagrant/code/nextcloud/lib/private/Files/View.php","line":1274,"function":"emit","class":"OC_Hook","type":"::","args":["OC_Filesystem","delete",{"run":true,"path":"/AAAAAAA/Test.md"}]},{"file":"/home/vagrant/code/nextcloud/lib/private/Files/View.php","line":1144,"function":"runHooks","class":"OC\\Files\\View","type":"->","args":[["delete"],"/AAAAAAA/Test.md"]},{"file":"/home/vagrant/code/nextcloud/lib/private/Files/View.php","line":718,"function":"basicOperation","class":"OC\\Files\\View","type":"->","args":["unlink","/Test.md",["delete"]]},{"file":"/home/vagrant/code/nextcloud/apps/dav/lib/Connector/Sabre/File.php","line":466,"function":"unlink","class":"OC\\Files\\View","type":"->","args":["/Test.md"]},{"file":"/home/vagrant/code/nextcloud/3rdparty/sabre/dav/lib/DAV/Tree.php","line":183,"function":"delete","class":"OCA\\DAV\\Connector\\Sabre\\File","type":"->","args":[]},{"file":"/home/vagrant/code/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php","line":295,"function":"delete","class":"Sabre\\DAV\\Tree","type":"->","args":["Test.md"]},{"file":"/home/vagrant/code/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php","line":89,"function":"httpDelete","class":"Sabre\\DAV\\CorePlugin","type":"->","args":[{"__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]},{"file":"/home/vagrant/code/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":474,"function":"emit","class":"Sabre\\DAV\\Server","type":"->","args":["method:DELETE",[{"__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]]},{"file":"/home/vagrant/code/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":251,"function":"invokeMethod","class":"Sabre\\DAV\\Server","type":"->","args":[{"__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]},{"file":"/home/vagrant/code/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":319,"function":"start","class":"Sabre\\DAV\\Server","type":"->","args":[]},{"file":"/home/vagrant/code/nextcloud/apps/dav/appinfo/v1/publicwebdav.php","line":113,"function":"exec","class":"Sabre\\DAV\\Server","type":"->","args":[]},{"file":"/home/vagrant/code/nextcloud/public.php","line":81,"args":["/home/vagrant/code/nextcloud/apps/dav/appinfo/v1/publicwebdav.php"],"function":"require_once"}],"File":"/home/vagrant/code/nextcloud/apps/activity/lib/FilesHooks.php","Line":193,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36","version":"21.0.0.0"}

Server configuration

PHP version: 7.4

Nextcloud version: master (see Nextcloud admin page)

[tgurr]

After applying the mentioned nextcloud/server#23256 and #506 I now get

{"reqId":"X33bx6jNyd41v1KrlvZGhQAATAA","level":4,"time":"2020-10-07T15:16:23+00:00","remoteAddr":"xxx.xxx.xxx.xxx","user":"--","app":"webdav","method":"DELETE","url":"/public.php/webdav/DSC_3335.JPG","message":{"Exception":"ArgumentCountError","Message":"Too few arguments to function OC\\TagManager::getUsersFavoritingObject(), 1 passed in /var/www/nextcloud.domain.local/htdocs/apps/activity/lib/FilesHooks.php on line 192 and exactly 2 expected","Code":0,"Trace":[{"file":"/var/www/nextcloud.domain.local/htdocs/apps/activity/lib/FilesHooks.php","line":192,"function":"getUsersFavoritingObject","class":"OC\\TagManager","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/apps/activity/lib/FilesHooks.php","line":241,"function":"getFileChangeActivitySettings","class":"OCA\\Activity\\FilesHooks","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/apps/activity/lib/FilesHooks.php","line":176,"function":"addNotificationsForFileAction","class":"OCA\\Activity\\FilesHooks","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/apps/activity/lib/FilesHooksStatic.php","line":63,"function":"fileDelete","class":"OCA\\Activity\\FilesHooks","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/lib/private/legacy/OC_Hook.php","line":110,"function":"fileDelete","class":"OCA\\Activity\\FilesHooksStatic","type":"::"},{"file":"/var/www/nextcloud.domain.local/htdocs/lib/private/Files/View.php","line":1274,"function":"emit","class":"OC_Hook","type":"::"},{"file":"/var/www/nextcloud.domain.local/htdocs/lib/private/Files/View.php","line":1144,"function":"runHooks","class":"OC\\Files\\View","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/lib/private/Files/View.php","line":718,"function":"basicOperation","class":"OC\\Files\\View","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/apps/dav/lib/Connector/Sabre/File.php","line":466,"function":"unlink","class":"OC\\Files\\View","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/3rdparty/sabre/dav/lib/DAV/Tree.php","line":183,"function":"delete","class":"OCA\\DAV\\Connector\\Sabre\\File","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/3rdparty/sabre/dav/lib/DAV/CorePlugin.php","line":295,"function":"delete","class":"Sabre\\DAV\\Tree","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/3rdparty/sabre/event/lib/WildcardEmitterTrait.php","line":89,"function":"httpDelete","class":"Sabre\\DAV\\CorePlugin","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/3rdparty/sabre/dav/lib/DAV/Server.php","line":474,"function":"emit","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/3rdparty/sabre/dav/lib/DAV/Server.php","line":251,"function":"invokeMethod","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/3rdparty/sabre/dav/lib/DAV/Server.php","line":319,"function":"start","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/apps/dav/appinfo/v1/publicwebdav.php","line":113,"function":"exec","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud.domain.local/htdocs/public.php","line":81,"args":["/var/www/nextcloud.domain.local/htdocs/apps/dav/appinfo/v1/publicwebdav.php"],"function":"require_once"}],"File":"/var/www/nextcloud.domain.local/htdocs/lib/private/TagManager.php","Line":96,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.89 Safari/537.36","version":"20.0.0.9","id":"5f7ddbc8531f7"}

when trying to delete a file, is there something else missing?

[kesselb]

Thanks for testing @tgurr 👍 I guess the first argument should be 'files' and the object id the second one.

cc @nickvergessen

[nickvergessen]

PR is already in #506

[kesselb]

PR is already in #506

He tested the patch and run into: Too few arguments to function OC\\TagManager::getUsersFavoritingObject(), 1 passed in /apps/activity/lib/FilesHooks.php on line 192 and exactly 2 expected.

activity/lib/FilesHooks.php

Line 193 in 881b16f

$favoriteUsers = $this->tagManager->getUsersFavoritingObject($fileId);

I guess the object type is missing.

[nickvergessen]

Ah right, sorry didn't read good enough I guess

[nickvergessen]

@tgurr I added another commit on #506 if you want to test it.

[tgurr]

@nickvergessen appears to work for me, thanks!