[Bug]: Theming: Default Background Image does not use instance color

[newhinton]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• Nextcloud Server is running on 64bit capable CPU, PHP and OS.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

When the user changes the background image, the color gets changed. For the Default Image, the nextcloud-default-blue is used, NOT the instance-color set by an admin. Therefore it is not possible to get back to the "defaults".

Steps to reproduce

1. Change Background Image away from Default
2. Change Image back to default.

Expected behavior

The color should now be what was set in the global theming app, in my case red.
Instead it is blue.

Installation method

Community Manual installation with Archive

Operating system

Debian/Ubuntu

PHP engine version

PHP 7.4

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated to a major version (ex. 22.2.3 to 23.0.1)

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

- theming: 2.0.1

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

[skjnldsv]

@newhinton fixed in 25.0.1, no?

[newhinton]

No it is present in 25.0.1.

Though i am not sure if i used the beta-channel to update.

[skjnldsv]

If you went through the beta, there might have been some config loss in the background config you might have chosen before.

For me it works properly.
There is one flow that might be confusing though, can you confirm this is what you are refering to or not?

1. Admin set color to COLOR1
2. User select plain background. User now have COLOR1 as a background
3. Admin set new color to COLOR2
4. User STILL have COLOR1 defined

If this is about that, then it's per design. "plain background" is a one-time set option.
This is not "Follow instance colors".

[newhinton]

@skjnldsv

No your usecase is wrong:

1. Admin set color to COLOR1, background to IMAGE
2. User select Arbitrary Setting beside Default Image.
3. User select Default Image. User now have IMAGE as a background, COLOR1 as accent color
4. Admin set new color to COLOR2, changes background image to IMAGE2
5. User also have COLOR2 defined as accent color, and background is now IMAGE2

That is not how i expect it to work. I expect that Default Image is what the instance set's as default, not the "nextcloud-default".

Currently it works like that:

1. Admin set color to COLOR1, background to IMAGE
2. User select Arbitrary Setting beside Default Image.
3. User select Default Image. User now have IMAGE as a background, COLOR1 as accent color
4. Admin set new color to COLOR2, changes background image to IMAGE2
5. User only have IMAGE2 as background image, BUT Nextcloud Blue as accent color.

The last part is the one that works not as expected.

In 25.0.2rc2 it is still not working as expected, though i upgraded from an old config/data-dir, i will check a fresh install now.

Edit:

It seems a fresh install is not affected (944be79)