Merged
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
enhancement
design
|
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv, @LukasReschke and @jbtbnl to be potential reviewers. |
Merged
Member
|
👍 |
Member
|
LGTM 👍 |
MorrisJobke
added
4. to release
Member
|
So you really want to break your app so it does require a minor update before being usable? |
Member
Author
|
No, but it will take some time for it to be released anyway. We backported the audio and video icons already so it would be a bit stupid to not do it with the fullscreen icon either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1803
Please review @LukasReschke @skjnldsv @MorrisJobke