feat: move file cache from view to node api#52000
Open
icewind1991 wants to merge 3 commits intomasterfrom
Open
feat: move file cache from view to node api#52000icewind1991 wants to merge 3 commits intomasterfrom
icewind1991 wants to merge 3 commits intomasterfrom
Conversation
icewind1991
requested review from
Altahrim,
come-nc and
skjnldsv
and removed request for
a team
icewind1991
force-pushed
the
files-cache-node
branch
from
e61a052 to
5556307
Compare
come-nc
reviewed
Apr 7, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Where is this class used? I can only find it used for registering its garbage collector.
icewind1991
force-pushed
the
files-cache-node
branch
6 times, most recently
from
e382471 to
c89e3c2
Compare
skjnldsv
approved these changes
Apr 8, 2025
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Merged
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 11, 2026
Merged
Merged
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
files-cache-node
branch
from
c89e3c2 to
7ce6a54
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
files-cache-node
branch
from
7ce6a54 to
82e6977
Compare
| protected function run(mixed $argument): void { | ||
| $offset = $this->appConfig->getValueInt('core', 'files_gc_offset'); | ||
|
|
||
| $users = $this->userManager->getSeenUsers($offset); |
Member
There was a problem hiding this comment.
It's an int offset and starting over will catch newly added users, so that is not a problem I guess? 🙈
| return; | ||
| } | ||
| } | ||
| $this->appConfig->setValueInt('core', 'files_gc_offset', 0); |
Member
There was a problem hiding this comment.
This however always resets to the start, if the gc for the 1k users in above loop took less then 23h, it will never do page 2+
| $now = time(); | ||
|
|
||
| // almost time for the next job run, stop early and save our location | ||
| if ($now - $start > 23 * 60 * 60) { |
Member
There was a problem hiding this comment.
Should stop after ~6h if possible so the "maintenance window" is respected.
On the other side if the instance has millions of users, if we only do 1k users per night, this will not scale?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changes the explicit full-filesystem setup to the normal implicit filesystem setup that can do the optimized path of only setting up the home storage.