Skip to content

refactor(comments): migrate to Vue 3#58353

Merged
susnux merged 7 commits intomasterfrom
refactor/55428/comments
Apr 1, 2026
Merged

refactor(comments): migrate to Vue 3#58353
susnux merged 7 commits intomasterfrom
refactor/55428/comments

Conversation

@edward-ly
Copy link
Copy Markdown
Contributor

@edward-ly edward-ly commented Feb 16, 2026 •
edited by susnux
Loading

Summary

Details

TODO

Currently, npm run dev/build fails with this error. I suspect it has something to do with the CommentInstance class requiring a Vue 2 options object which I'm not yet sure how to cleanly migrate to Vue 3.

error during build:
[vite:css-post] object null is not iterable (cannot read property Symbol(Symbol.iterator))
    at assetFileNames (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/.vite-temp/vite.config.ts.timestamp-1771208851828-a019a06c76d568.mjs:95:33)
    at Object.assetFileNames (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/@nextcloud/vite-config/dist/plugins/CSSEntryPoints.js:28:65)
    at generateAssetFileName (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21662:25)
    at FileEmitter.finalizeAdditionalAsset (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21955:28)
    at FileEmitter.emitAssetWithReferenceId (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21899:18)
    at FileEmitter.emitAsset (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21884:18)
    at FileEmitter.emitFile (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:21745:25)
    at Object.renderChunk (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/vite/dist/node/chunks/config.js:29806:32)
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)
    at async transformChunk (file:///home/edward/projects/nextcloud/nextcloud-docker-dev/workspace/server/node_modules/rollup/dist/es/shared/node-entry.js:20311:16)

Checklist

@edward-ly edward-ly added this to the Nextcloud 34 milestone Feb 16, 2026
@edward-ly edward-ly added 3. to review Waiting for reviews feature: comments technical debt 🧱 🤔🚀 javascript ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Feb 16, 2026
susnux
susnux reviewed Feb 22, 2026
View reviewed changes
Comment thread package.json Outdated
susnux
susnux reviewed Feb 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking care of this :)

Comment thread apps/comments/lib/Listener/LoadSidebarScripts.php Outdated
Comment thread apps/comments/src/services/CommentsInstance.ts Outdated
@susnux

This comment was marked as outdated.

Sign in to view
@susnux susnux mentioned this pull request Feb 22, 2026
Merged
6 tasks
@susnux susnux force-pushed the refactor/55428/comments branch 2 times, most recently from a3c227e to 560576f Compare February 23, 2026 09:28
@susnux

This comment was marked as resolved.

Sign in to view
@edward-ly edward-ly force-pushed the refactor/55428/comments branch from 560576f to 80613d8 Compare February 25, 2026 07:19
@edward-ly
Copy link
Copy Markdown
Contributor Author

edward-ly commented Feb 25, 2026

Currently, npm run dev/build fails with this error.

Fix for this: #58505

It looks like that did the trick. All suggestions so far have now been applied as well.

Although, I am currently seeing this in the comments tab, and I'm not sure how to fix it. I'm guessing it has something to do with the fact the NcRichContenteditable component is dynamically loaded.

Screenshot 2026-02-24 at 23-18-38 Media - All files - Nextcloud

@edward-ly edward-ly force-pushed the refactor/55428/comments branch from 80613d8 to 5ffc49b Compare February 25, 2026 07:42
@susnux susnux mentioned this pull request Mar 25, 2026
Open
32 tasks
@susnux susnux force-pushed the refactor/55428/comments branch from 5ffc49b to b4b6652 Compare April 1, 2026 00:20
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Apr 1, 2026

Although, I am currently seeing this in the comments tab, and I'm not sure how to fix it. I'm guessing it has something to do with the fact the NcRichContenteditable component is dynamically loaded.

Rebased and pushed this as a fix for it: b4b6652

@susnux susnux marked this pull request as ready for review April 1, 2026 12:33
@susnux susnux requested review from a team as code owners April 1, 2026 12:33
@susnux susnux requested review from leftybournes, nfebe, salmart-dev, sorbaugh and szaimen and removed request for a team April 1, 2026 12:33
susnux
susnux approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works fine ✅

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 1, 2026
@skjnldsv
Copy link
Copy Markdown
Member

skjnldsv commented Apr 1, 2026

Thanks @edward-ly !

edward-ly and others added 6 commits April 1, 2026 14:54
@edward-ly @susnux
build(comments): move from frontend-legacy to frontend
4edf863 
Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly @susnux
refactor(comments): migrate to TypeScript
3aa2280 
Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly @susnux
refactor(comments): migrate to Vue 3
c56ebce 
Signed-off-by: Edward Ly <contact@edward.ly>
@susnux
chore: fix ESLint errors
e26588d 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: add compatibility layer for apps expecting Vue 2 API
324ebd1 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: properly load async components
e8c47cf 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the refactor/55428/comments branch from b4b6652 to e8c47cf Compare April 1, 2026 12:54
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Apr 1, 2026

/compile

@nextcloud-command
chore(assets): Recompile assets
78098c8 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@edward-ly
Copy link
Copy Markdown
Contributor Author

edward-ly commented Apr 1, 2026

Thanks @susnux for cleaning this up!

@susnux susnux merged commit 03c318d into master Apr 1, 2026
238 of 254 checks passed
@susnux susnux deleted the refactor/55428/comments branch April 1, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: comments javascript ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

4 participants

@edward-ly @susnux @skjnldsv @nextcloud-command