[stable30] Fix federated reshares#58992
Merged
Conversation
provokateurin
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if ($send) { | ||
| $ownerCloudId = $this->cloudIdManager->getCloudId($remoteShare['owner'], $remoteShare['remote']); | ||
| $shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_' . time(), $shareType, $expirationDate); | ||
| [$token, $remoteId] = $this->notifications->requestReShare( |
Check notice
Code scanning / Psalm
PossiblyInvalidArrayAccess Note
| if ($send) { | ||
| $ownerCloudId = $this->cloudIdManager->getCloudId($remoteShare['owner'], $remoteShare['remote']); | ||
| $shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_' . time(), $shareType, $expirationDate); | ||
| [$token, $remoteId] = $this->notifications->requestReShare( |
Check notice
Code scanning / Psalm
PossiblyInvalidArrayAccess Note
Contributor
|
Same issue here with the share ID being int instead of string. |
salmart-dev
previously requested changes
Mar 17, 2026
provokateurin
force-pushed
the
backport/58689/stable30
branch
from
3ed0dcc to
5f02191
Compare
| [$token, $remoteId] = $this->notifications->requestReShare( | ||
| $remoteShare['share_token'], | ||
| $remoteShare['remote_id'], | ||
| $shareId, |
Check notice
Code scanning / Psalm
InvalidArgument Note
provokateurin
force-pushed
the
backport/58689/stable30
branch
from
5f02191 to
bebc765
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
…r might on another server Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
backport/58689/stable30
branch
from
bebc765 to
eb9f88e
Compare
salmart-dev
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #58689