fix(dav): adjust password session check on legacy dav auth#59374
Open
fix(dav): adjust password session check on legacy dav auth#59374
Conversation
skjnldsv
added
bug
3. to review
skjnldsv
requested review from
icewind1991,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
Member
Author
|
/backport to stable32 please |
Member
Author
|
/backport to stable33 please |
Member
Author
|
/backport to stable31 please |
skjnldsv
force-pushed
the
fix/legacy-dav-session-check
branch
from
62ded5b to
ca7e275
Compare
Follow-up #55955 Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
fix/legacy-dav-session-check
branch
from
ca7e275 to
fdfa8eb
Compare
CarlSchwan
reviewed
Apr 1, 2026
Comment on lines
+122
to
+126
| if (!is_array($allowedShareIds)) { | ||
| return false; | ||
| } | ||
|
|
||
| return in_array($share->getId(), $allowedShareIds); |
Member
There was a problem hiding this comment.
Suggested change
| if (!is_array($allowedShareIds)) { | |
| return false; | |
| } | |
| return in_array($share->getId(), $allowedShareIds); | |
| if (!is_array($allowedShareIds)) { | |
| return false; | |
| } | |
| return in_array($share->getId(), $allowedShareIds, true); |
Strict mode :)
Contributor
|
/backport! to stable31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #55955
Summary
We adjusted the session to store multiple granted public shares, so you could open a few tabs and not get logge dout the previous ones.
But I did not migrate the legacy auth middleware. It seems it's still used in older versions, maybe we plan the removal of the old dav v1 entrypoint
Checklist
3. to review, feature component)stable32)AI (if applicable)