Skip to content

feat: Implement PSR-18 ClientInterface in IClient#59530

Merged
CarlSchwan merged 1 commit intonextcloud:masterfrom
SMillerDev:feat/http/psr-18
Apr 14, 2026
Merged

feat: Implement PSR-18 ClientInterface in IClient#59530
CarlSchwan merged 1 commit intonextcloud:masterfrom
SMillerDev:feat/http/psr-18

Conversation

@SMillerDev
Copy link
Copy Markdown
Contributor

@SMillerDev SMillerDev commented Apr 9, 2026

Summary

This makes sure the IClient is compliant with PSR-18. This means that any PSR-18 client could be dropped in as a backing client in the future, and it also means that any library using PSR-18 to communicate with a HTTP client can use IClient

TODO

  • Make sure all CI works

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@SMillerDev SMillerDev requested a review from a team as a code owner April 9, 2026 09:22
@SMillerDev SMillerDev requested review from ArtificialOwl, artonge, leftybournes and salmart-dev and removed request for a team April 9, 2026 09:22
@artonge artonge requested review from come-nc and provokateurin April 9, 2026 10:37
@susnux susnux added enhancement 3. to review Waiting for reviews labels Apr 9, 2026
@susnux susnux added this to the Nextcloud 34 milestone Apr 9, 2026
@come-nc
Copy link
Copy Markdown
Contributor

come-nc commented Apr 9, 2026

composer run cs:fix should fix the code style.

Comment thread lib/public/Http/Client/IClient.php
Comment thread lib/private/Http/Client/Client.php Outdated
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
@SMillerDev
Copy link
Copy Markdown
Contributor Author

Anyone know how I can get the cypress tests to pass?

@provokateurin
Copy link
Copy Markdown
Member

Just need to restart them until they pass 🙈

@CarlSchwan CarlSchwan merged commit c2cefcc into nextcloud:master Apr 14, 2026
195 of 200 checks passed
@nickvergessen
Copy link
Copy Markdown
Member

nickvergessen commented Apr 15, 2026

To the main-maintainers: there are 2 things that should to be checked/confirmed when we expose PSR interfaces:

@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nextcloud-bot nextcloud-bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP client docs

6 participants