feat: Implement PSR-18 ClientInterface in IClient#59530
feat: Implement PSR-18 ClientInterface in IClient#59530CarlSchwan merged 1 commit intonextcloud:masterfrom
Conversation
|
|
7a88bdd to
f5f12f0
Compare
f5f12f0 to
89bced4
Compare
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
89bced4 to
769198b
Compare
|
Anyone know how I can get the cypress tests to pass? |
|
Just need to restart them until they pass 🙈 |
|
To the main-maintainers: there are 2 things that should to be checked/confirmed when we expose PSR interfaces:
|
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
This makes sure the
IClientis compliant with PSR-18. This means that any PSR-18 client could be dropped in as a backing client in the future, and it also means that any library using PSR-18 to communicate with a HTTP client can useIClientTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)